Skip to content
This repository was archived by the owner on Jul 31, 2023. It is now read-only.

Replace tag.NewKey calls with tag.MustNewKey where appropriate#1146

Merged
rghetia merged 1 commit intocensus-instrumentation:masterfrom
semistrict:replace-newkey
Jun 11, 2019
Merged

Replace tag.NewKey calls with tag.MustNewKey where appropriate#1146
rghetia merged 1 commit intocensus-instrumentation:masterfrom
semistrict:replace-newkey

Conversation

@semistrict
Copy link
Copy Markdown
Contributor

@semistrict semistrict commented Jun 10, 2019

No description provided.

@semistrict semistrict requested review from a team, rakyll and rghetia as code owners June 10, 2019 22:36
@googlebot
Copy link
Copy Markdown

googlebot commented Jun 10, 2019

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link
Copy Markdown

googlebot commented Jun 10, 2019

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@semistrict semistrict force-pushed the replace-newkey branch 2 times, most recently from 8c01d8b to 964f1e6 Compare June 10, 2019 22:58
rghetia
rghetia reviewed Jun 10, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@rghetia rghetia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from build error.

@rghetia rghetia merged commit f6172e4 into census-instrumentation:master Jun 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@rakyll rakyll Awaiting requested review from rakyll

1 more reviewer

@rghetia rghetia rghetia approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@semistrict @googlebot @rghetia