go.mod: update to OpenCensus-Proto v0.2.0#48
go.mod: update to OpenCensus-Proto v0.2.0#48odeke-em merged 2 commits intocensus-ecosystem:masterfrom
Conversation
songy23
left a comment
There was a problem hiding this comment.
I think you'll need to fix a few backwards-incompatible changes in proto.
Updated to OpenCensus-Proto v0.2.0 but also ran `go mod tidy` too for a clean-up of old resources.
7e542d8 to
472362a
Compare
@songy23 roger that, I updated the Proto version as you did in census-ecosystem/opencensus-go-exporter-stackdriver#102 |
|
And some errors from that update contrib.go.opencensus.io/exporter/ocagent
# contrib.go.opencensus.io/exporter/ocagent
./ocagent.go:297:35: cannot convert true (type untyped bool) to type "github.com/census-instrumentation/opencensus-proto/gen-go/trace/v1".ConstantSampler_ConstantDecision
./ocagent.go:297:35: invalid operation: csamp.Decision == true (mismatched types "github.com/census-instrumentation/opencensus-proto/gen-go/trace/v1".ConstantSampler_ConstantDecision and bool)
./transform_stats_to_metrics.go:53:3: unknown field 'Descriptor_' in struct literal of type "github.com/census-instrumentation/opencensus-proto/gen-go/metrics/v1".Metric
./transform_stats_to_metrics.go:59:45: undefined: "github.com/census-instrumentation/opencensus-proto/gen-go/metrics/v1".Metric_MetricDescriptor
./transform_stats_to_metrics.go:67:11: undefined: "github.com/census-instrumentation/opencensus-proto/gen-go/metrics/v1".Metric_MetricDescriptor |
Yes, those are the backwards-incompatible changes that I'm referring to (census-instrumentation/opencensus-proto#184 and census-instrumentation/opencensus-proto#182). |
Please fix. |
d1a1ce4 to
33225ca
Compare
|
@songy23 alright, just one left from OpenCensus-Proto # github.com/census-instrumentation/opencensus-proto/gen-go/agent/common/v1
../../../../pkg/mod/github.com/census-instrumentation/opencensus-proto@v0.2.0/gen-go/agent/common/v1/common.pb.go:22:11: undefined: proto.ProtoPackageIsVersion3
# github.com/census-instrumentation/opencensus-proto/gen-go/resource/v1
../../../../pkg/mod/github.com/census-instrumentation/opencensus-proto@v0.2.0/gen-go/resource/v1/resource.pb.go:21:11: undefined: proto.ProtoPackageIsVersion3 |
|
From what I saw the error is different (https://travis-ci.org/census-ecosystem/opencensus-go-exporter-ocagent/builds/505582131#L678): # contrib.go.opencensus.io/exporter/ocagent_test [contrib.go.opencensus.io/exporter/ocagent.test]
./ocagent_test.go:57:47: cannot use true (type bool) as type "github.com/census-instrumentation/opencensus-proto/gen-go/trace/v1".ConstantSampler_ConstantDecision in field value
./ocagent_test.go:85:47: cannot use false (type bool) as type "github.com/census-instrumentation/opencensus-proto/gen-go/trace/v1".ConstantSampler_ConstantDecision in field value
This should be fixed as long as you used v1.3.0 for protobuf. |
33225ca to
7aed492
Compare
songy23
left a comment
There was a problem hiding this comment.
Thanks for looking into this!
|
Thank you for the review @songy23! |
|
I'll just publish a new version then we'll be gucci to go. |
Updated to OpenCensus-Proto v0.2.0 but also
ran
go mod tidytoo for a clean-up of oldresources.