Adds minute offset to hourly scheduling#54
Closed
Frazzer951 wants to merge 1 commit intocenodude:mainfrom
Closed
Conversation
Enables specifying a minute offset for hourly scheduled tasks. This allows for finer-grained control over when tasks are executed, preventing potential resource contention or staggering tasks across different systems.
Owner
|
Hi, I’ll review it later this week. Not used to people trying to help with this project., so thanks. 😄 really kind of you. |
Owner
|
Sorry! I almost forgot about you. I reviewed the change and I’m not going to merge it. The main issue isn’t the code, it’s the functionality: I want to keep CrossWatch simpler, since it’s already challenging for a lot of users. Adding things like an offset doesn’t really help with that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that when setting the schedule to
Every N hoursit would keep the minute of when you saved the config instead.I.E. If I did every 4 hours at 10:06 it would set the scheduled next run to be at 14:06. I would have expected it to be just 14:00.
I didn't know if keeping the minutes was intentional so I also added a config where you can set which minute to run on.
So now if I set it to run every 4 hours and set
minute_offsetto 0, at 10:06 the next run will be at 14:00.Please let me know of any further changes you would like me to make.