chore: fixes dead link for golangci-lint status badge in README#254
Merged
chore: fixes dead link for golangci-lint status badge in README#254
Conversation
rootulp
previously approved these changes
May 13, 2024
README.md
Outdated
|  | ||
| [](https://pkg.go.dev/github.com/celestiaorg/nmt) | ||
|  | ||
|  |
Collaborator
There was a problem hiding this comment.
Hmm if I go to that link it says no status. We could also get rid of the badge entirely
Suggested change
|  |
Contributor
Author
There was a problem hiding this comment.
I am down with removing it entirely cc: @evan-forbes wdyt?
Contributor
Author
There was a problem hiding this comment.
I changed the url to use the default branch of main(removed the branch parameter results in using the default branch of main). With this change the status badge is failing, which I think should become passing after this PR.
Update: the badge is now passing.
evan-forbes
previously approved these changes
May 14, 2024
rootulp
approved these changes
May 16, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #254 +/- ##
=======================================
Coverage 66.24% 66.24%
=======================================
Files 6 6
Lines 1022 1022
=======================================
Hits 677 677
Misses 328 328
Partials 17 17 ☔ View full report in Codecov by Sentry. |
evan-forbes
approved these changes
May 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The status badge for the the golangci-lint workflow fails to load. This PR fixes the link and resolves the issue.