Merged
Conversation
9e1abe7 to
5f30795
Compare
Codecov Report
@@ Coverage Diff @@
## master #149 +/- ##
=======================================
Coverage 96.20% 96.20%
=======================================
Files 6 6
Lines 527 527
=======================================
Hits 507 507
Misses 12 12
Partials 8 8 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Collaborator
|
Test passes so seems safe to merge. |
rootulp
approved these changes
Aug 18, 2025
Collaborator
|
golangci-lint is fixed in #294 |
rach-id
approved these changes
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This is a PR for addition of new test cases that have been noticed to be missing through the audit of the nmt repository. The intention is to increase the number of test cases by adding tests for edge cases and for the issues that have been reported.
Checklist