Sentence case titles #163
Sentence case titles #163
Conversation
I preserved capitalization for H1s where the noun was the sidebar name (ex. `Full Storage Node`, `Bridge Node`, etc.) and sentence cased all other titles (H2+). Resolves celestiaorg#161
|
Hey @rootulp I'll get back to this next week, my general thinking though is that title case are fine in sub-headings as they're still titles. What is the thinking around lower-casing subheadings below H1? Is that part of a style guide you can link me to? |
|
No rush on reviewing this, next week is fine. We should align on whether we want #161
It's a style thing. https://design-system.service.gov.uk/styles/typography/#headings states:
but I'm sure we can find style guides that state the opposite. This PR was motivated by me noticing that the docs contain a lot of capitalization (in titles and paragraphs) which led to my confusion on which words were proper nouns. We probably don't need sentence-cased titles if we do #160 along with downcasing words in paragraphs that aren't proper nouns. |
|
I can go either way, although not too sure on the new styling. @dabit3 any thoughts? |
|
Looks good to me, only question is "what do we consider proper nouns" I.e. are Light / Bridge / Full / etc... nodes a proper noun? Or is it just at type of Celestia node? |
I think just a type of node. For example "light client" and "light node" are not capitalized in: |
|
@rootulp makes sense, looks great to me! |
I preserved capitalization for H1s where the noun was the sidebar name (ex.
Full Storage Node,Bridge Node, etc.) and sentence cased all other titles (H2+).Resolves #161