Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @cmwaters, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request advances the lifecycle of Celestia Improvement Proposal (CIP) 34 by changing its official status. This indicates that the proposal has undergone its primary review phase and is now entering a final period for community feedback before potential finalization.
Highlights
- CIP Status Update: The status of CIP-034, which describes setting the minimum data pruning window for DA bridge nodes, has been updated from
ReviewtoLast Call.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates the status of CIP-34 from 'Review' to 'Last Call'. My review has identified a potential process issue: CIP-34 has a dependency on CIP-36, which is currently in 'Draft' status. I've raised a concern that a CIP should not be advanced before its dependencies are in a more mature state to avoid potential inconsistencies.
| | author | Callum Waters ([@cmwaters](https://github.com/cmwaters)), Nashqueue ([@Nashqueue](https://github.com/Nashqueue)) | | ||
| | discussions-to | <https://forum.celestia.org/t/cip-lower-data-pruning-window-to-7-days-1-hour/1965> | | ||
| | status | Review | | ||
| | status | Last Call | |
There was a problem hiding this comment.
This CIP is being moved to 'Last Call', but it depends on CIP-36 which is still in 'Draft' status (as seen in cips/cip-036.md).
From this file (cips/cip-034.md):
- Line 11:
requires: CIP-036 - Line 32: "This CIP's proposed change to the
MinimumPruningWindowshould be implemented after the changes specified in CIP-036 ... are adopted by the network."
Advancing a CIP to 'Last Call' while its dependency is still a 'Draft' can lead to inconsistencies if CIP-36 undergoes significant changes or is rejected. It's generally expected that dependencies are in a more mature state (e.g., 'Last Call' or 'Final') before the dependent CIP advances this far.
To maintain a consistent and logical progression of proposals, it's recommended to either advance CIP-36 first or keep CIP-34 in 'Review' until its dependency has matured.
Co-authored-by: Rootul P <rootulp@gmail.com>
|
SGTM |
|
Yeah that makes sense @jcstein. After todays call, we can move both to last call then - how does that sound? |
|
SGTM, but didn't see this until now |
No description provided.