Remove sampling window from CIP#310
Merged
rootulp merged 2 commits intocelestiaorg:mainfrom Jun 11, 2025
Merged
Conversation
rootulp
approved these changes
Jun 9, 2025
cmwaters
reviewed
Jun 10, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR refocuses CIP-034 on configuring the data pruning window to 7 days + 1 hour and removes references to sampling logic, delegating sampling details to CIP-036.
- Updated title, description, and metadata to target pruning only
- Adjusted parameters table to reflect new PruningWindow values
- Revised rationale and backwards compatibility sections to isolate pruning changes
Comments suppressed due to low confidence (2)
cips/cip-034.md:26
- [nitpick] Add a comma before 'which' or rephrase the clause for clarity, e.g., '...7 TB, making it less costly to serve data to the network.'
This CIP reduces the pruning window to 7 days + 1 hour to reduce the storage requirement to 7 TB which makes it less costly to serve data to the network.
cips/cip-034.md:32
- [nitpick] The phrase 'ensure light nodes don't sample correctly pruned data' is unclear. Consider rewording to 'ensure light nodes can correctly sample pruned data.'
Nodes must first support the new `SamplingWindow` before the `PruningWindow` is reduced to 7 days + 1 hour to ensure light nodes dont sample correctly pruned data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Removes sampling window from CIP . Builds on top of #309