Conversation
Contributor
|
i have a link to the code but its quite large to include here, what is the preferred path? |
Collaborator
Author
|
Yaz wanted to avoid links in the CIPs repo and instead to copy + paste content directly into this repo. I think the rationale was that the links could break and/or the original content that was hosted externally could go down. I'm fine with adding a link to the PR in the reference implementation section of this CIP. |
Member
|
this is the current guidance: https://cips.celestia.org/cip-001.html#linking-to-external-resources happy to change this too if we think it's safe |
jcstein
approved these changes
Mar 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is there a reference implementation I can add to the detailed design / reference implementation section? @tac0turtle