Skip to content

feat: Versioned timeouts CIP draft#216

Merged
jcstein merged 28 commits intomainfrom
jcs/cip-6-seconds
Oct 17, 2024
Merged

feat: Versioned timeouts CIP draft#216
jcstein merged 28 commits intomainfrom
jcs/cip-6-seconds

Conversation

@jcstein
Copy link
Copy Markdown
Member

@jcstein jcstein commented Oct 10, 2024

Overview

@jcstein jcstein requested a review from staheri14 October 10, 2024 14:37
jcstein and others added 2 commits October 10, 2024 15:35
@jcstein jcstein requested a review from rootulp October 16, 2024 01:05

The motivation for this CIP stems from a discussion in Core Devs Call 17, where it was proposed to reduce the block time to 6 seconds from 12 seconds.

## Specification
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this specification section should include a short blurb on why TimeoutCommit and TimeoutPropose were moved from local config parameters into versioned parameters controlled by the state machine. cc: @staheri14

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using this for now "The TimeoutCommit and TimeoutPropose parameters were moved from local config parameters into versioned parameters controlled by the state machine to ensure consistency and correctness across different protocol versions. This change allows the system to adapt dynamically to version-specific requirements, improving overall stability and interoperability during upgrades."

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcstein jcstein requested a review from rootulp October 16, 2024 14:58
Copy link
Copy Markdown
Contributor

@staheri14 staheri14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested a few changes as requested @jcstein

@jcstein
Copy link
Copy Markdown
Member Author

jcstein commented Oct 17, 2024

thank you @staheri14!

Co-authored-by: Sanaz Taheri <35961250+staheri14@users.noreply.github.com>
@jcstein jcstein changed the title feat: add 6 second block CIP draft feat: Versioned timeouts CIP draft Oct 17, 2024
Co-authored-by: Sanaz Taheri <35961250+staheri14@users.noreply.github.com>
@jcstein jcstein merged commit edd2e09 into main Oct 17, 2024
@jcstein jcstein deleted the jcs/cip-6-seconds branch October 17, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants