Fix regex pattern in version parsing and remove duplicate entry in __all__ #9978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…all__ - Fix: Escape second dot in version parsing regex pattern The pattern r'(\d+)\.(\d+).(\d+)' incorrectly used unescaped dot which matches any character. Changed to r'(\d+)\.(\d+)\.(\d+)' to correctly match literal dots in version strings. - Fix: Remove duplicate 'gen_task_name' entry in celery/utils/__init__.py __all__ Removed redundant duplicate entry in the __all__ tuple.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses two minor code quality issues:
- Removes a duplicate export of
gen_task_namefrom thecelery/utils/__init__.pymodule's__all__list - Fixes a regex pattern bug in
celery/__init__.pywhere a literal dot was used instead of an escaped dot for version parsing
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| celery/utils/init.py | Removes duplicate gen_task_name entry from __all__ exports list |
| celery/init.py | Corrects regex pattern to properly escape the second dot in version string parsing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9978 +/- ##
=======================================
Coverage 78.68% 78.68%
=======================================
Files 153 153
Lines 19313 19313
Branches 2214 2214
=======================================
Hits 15196 15196
Misses 3817 3817
Partials 300 300
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
auvipy
approved these changes
Nov 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes two small bugs in the Celery codebase:
1. Bug Fix: Regex Pattern in Version Parsing
File:
celery/__init__.py(line 45)Issue: The regex pattern
r'(\d+)\.(\d+).(\d+)(.+)?'had an unescaped dot (.) between the minor and micro version numbers, which matches any character instead of a literal dot.Fix: Changed to
r'(\d+)\.(\d+)\.(\d+)(.+)?'to correctly match literal dots in version strings.Impact:
5.6X0b2would incorrectly match with old pattern)2. Code Quality: Remove Duplicate Entry
File:
celery/utils/__init__.py(line 25)Issue: Duplicate
'gen_task_name'entry in the__all__tuple.Fix: Removed the duplicate entry.
Impact: Cleaner code, no functional change.
Testing
Pre-PR Checklist
Note: These are simple bug fixes that don't require new unit tests as: