Skip to content

Conversation

@MehrazRumman
Copy link
Contributor

No description provided.

@MehrazRumman MehrazRumman marked this pull request as draft October 28, 2025 12:28
@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.68%. Comparing base (47b7b50) to head (1796bb1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9970   +/-   ##
=======================================
  Coverage   78.68%   78.68%           
=======================================
  Files         153      153           
  Lines       19313    19313           
  Branches     2214     2214           
=======================================
  Hits        15196    15196           
  Misses       3817     3817           
  Partials      300      300           
Flag Coverage Δ
unittests 78.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MehrazRumman MehrazRumman marked this pull request as ready for review October 28, 2025 14:52
@MehrazRumman
Copy link
Contributor Author

@auvipy I think The PR is ready for review, Thanks !

@auvipy auvipy requested review from auvipy and Copilot October 28, 2025 15:23
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the tblib dependency from version 3.1.0 to 3.2.0 and modifies exception handling tests to accommodate behavioral changes in the new version. The update appears to affect how unpickleable exceptions are serialized and returned in some environments.

Key changes:

  • Updated tblib dependency from 3.1.0 to 3.2.0
  • Modified two test cases to accept either UnpickleableExceptionWrapper or plain Exception instances with stringified error messages
  • Added fallback assertions checking for exception class name and arguments in string representations

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
requirements/extras/tblib.txt Updated tblib version constraint from 3.1.0 to 3.2.0
t/integration/test_tasks.py Modified exception assertions to handle both wrapped and stringified exception formats

@auvipy auvipy added this to the 5.6.0 milestone Oct 28, 2025
@auvipy auvipy merged commit 0c30c18 into celery:main Oct 28, 2025
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants