Pin tblib to ==3.1.0 #9967
Pin tblib to ==3.1.0 #9967
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9967 +/- ##
=======================================
Coverage 78.67% 78.67%
=======================================
Files 153 153
Lines 19304 19304
Branches 2212 2212
=======================================
Hits 15188 15188
Misses 3817 3817
Partials 299 299
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -1,2 +1 @@ | |||
| tblib>=1.5.0;python_version>='3.8.0' | |||
| tblib>=1.3.0;python_version<'3.8.0' | |||
| tblib==3.1.0 | |||
There was a problem hiding this comment.
Shouldn't this be tblib>=1.50,<3.2.0? This would allow users of Celery to have versions of tblib in the working version range, that may be used by other libraries of the project? This might force people to upgrade to a version incompatible with other dependencies.
| tblib==3.1.0 | |
| tblib>=1.50,<3.2.0 |
There was a problem hiding this comment.
it is better to stick to specific version. why should we try so old version?
Pin tblib to ==3.1.0 to ensure consistent traceback serialization across Python versions.