Skip to content

Conversation

@cclauss
Copy link
Contributor

@cclauss cclauss commented Sep 15, 2025

@codecov
Copy link

codecov bot commented Sep 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.71%. Comparing base (7c75fa7) to head (9b23f01).
⚠️ Report is 74 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9891   +/-   ##
=======================================
  Coverage   78.71%   78.71%           
=======================================
  Files         153      153           
  Lines       19258    19258           
  Branches     2561     2561           
=======================================
  Hits        15158    15158           
  Misses       3803     3803           
  Partials      297      297           
Flag Coverage Δ
unittests 78.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@auvipy
Copy link
Member

auvipy commented Sep 15, 2025

there is already a PR for this #9798

@cclauss
Copy link
Contributor Author

cclauss commented Sep 15, 2025

Closing in favor of #9798.
* #9798

@cclauss cclauss closed this Sep 15, 2025
@cclauss cclauss deleted the patch-1 branch September 15, 2025 14:11
@cclauss cclauss restored the patch-1 branch September 15, 2025 15:43
@cclauss cclauss reopened this Sep 15, 2025
@cclauss
Copy link
Contributor Author

cclauss commented Sep 15, 2025

Reopening because #9798 uses slanted quotes that prevent Python 3.14 from being found and installed. That pull request tells us nothing about why Python 3.14 fails because Python 3.14 is never installed.

@cclauss cclauss force-pushed the patch-1 branch 6 times, most recently from bb1161a to c07242d Compare September 17, 2025 20:36
@cclauss
Copy link
Contributor Author

cclauss commented Sep 17, 2025

The failing job is caused by an AttributeError: module 'subprocess' has no attribute '_USE_VFORK' when running tests with Python 3.14. This is happening in billiard/compat.py at line 196, where it accesses subprocess._USE_VFORK. In Python 3.14, this private attribute has been removed.

Copy link
Member

@Nusnus Nusnus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the integration and smoke tests CI?
Not blocking though

@cclauss
Copy link
Contributor Author

cclauss commented Sep 18, 2025

Some of those integration and smoke tests fail on Python 3.14 because of:

@cclauss cclauss requested a review from Nusnus September 18, 2025 06:49
@auvipy auvipy self-requested a review September 18, 2025 07:01
Copy link
Member

@Nusnus Nusnus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Nusnus
Copy link
Member

Nusnus commented Sep 18, 2025

Some of those integration and smoke tests fail on Python 3.14 because of:

Ok then let's go forward with this and close the debt once the other issues are finalized.

Thank you!

@Nusnus Nusnus merged commit f55bb5f into celery:main Sep 18, 2025
109 checks passed
@cclauss cclauss deleted the patch-1 branch September 18, 2025 11:32
@auvipy auvipy added this to the 5.6.0 milestone Sep 18, 2025
@cclauss
Copy link
Contributor Author

cclauss commented Sep 18, 2025

OK... Py3.14 will still fail some integration tests until a new billiard release is pushed to PyPI.

@auvipy
Copy link
Member

auvipy commented Sep 18, 2025

just to be cautious, we should wait to declare python 3.14 support in celery v5.6 release

@cclauss
Copy link
Contributor Author

cclauss commented Sep 18, 2025

I am good with that.

@Nusnus
Copy link
Member

Nusnus commented Sep 20, 2025

@Nusnus
Copy link
Member

Nusnus commented Sep 20, 2025

The last official release was in 2018:

Is this a hard-blocker @cclauss ?

@auvipy
Copy link
Member

auvipy commented Sep 21, 2025

librabbitmq is not a suggested package for new projects, but we can release a new version no problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants