-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
GitHub Actions: Test on Python 3.14 release candidate 2 #9891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9891 +/- ##
=======================================
Coverage 78.71% 78.71%
=======================================
Files 153 153
Lines 19258 19258
Branches 2561 2561
=======================================
Hits 15158 15158
Misses 3803 3803
Partials 297 297
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
there is already a PR for this #9798 |
|
Reopening because #9798 uses slanted quotes that prevent Python 3.14 from being found and installed. That pull request tells us nothing about why Python 3.14 fails because Python 3.14 is never installed. |
bb1161a to
c07242d
Compare
|
The failing job is caused by an AttributeError: module 'subprocess' has no attribute '_USE_VFORK' when running tests with Python 3.14. This is happening in billiard/compat.py at line 196, where it accesses subprocess._USE_VFORK. In Python 3.14, this private attribute has been removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about the integration and smoke tests CI?
Not blocking though
|
Some of those integration and smoke tests fail on Python 3.14 because of: |
Nusnus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Ok then let's go forward with this and close the debt once the other issues are finalized. Thank you! |
|
OK... Py3.14 will still fail some |
|
just to be cautious, we should wait to declare python 3.14 support in celery v5.6 release |
|
I am good with that.
|
|
The last official release was in 2018:
Is this a hard-blocker @cclauss ? |
|
librabbitmq is not a suggested package for new projects, but we can release a new version no problem. |
Description
Python v3.14 -- October 7th
Blocked by
pydantic>=2.12: