Feature: Add support credential_provider to Redis Backend #9879
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9879 +/- ##
==========================================
+ Coverage 78.70% 78.72% +0.02%
==========================================
Files 153 153
Lines 19258 19280 +22
Branches 2561 2567 +6
==========================================
+ Hits 15157 15179 +22
Misses 3803 3803
Partials 298 298
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@auvipy, can you re-review please? |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Redis credential providers to the Redis backend, allowing users to authenticate with Redis using credential provider classes instead of static username/password pairs. This addresses issue #8505 and enables more secure authentication patterns for Redis connections.
Key changes:
- Added configuration option
redis_backend_credential_providerfor setting credential providers - Implemented URL parameter support for credential providers in Redis connection strings
- Added comprehensive test coverage for both configuration and URL-based credential provider usage
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| celery/backends/redis.py | Core implementation of credential provider support in Redis backend |
| t/unit/backends/test_redis.py | Comprehensive test cases for credential provider functionality |
| docs/userguide/configuration.rst | Documentation for the new redis_backend_credential_provider setting |
| docs/getting-started/backends-and-brokers/redis.rst | User guide documentation with credential provider URL examples |
| requirements/test.txt | Added additional test dependencies for azureblockblob and gevent |
auvipy
left a comment
There was a problem hiding this comment.
what about renaming the new config to just redis_credential_provider?
|
@auvipy What is your reasoning to rename to |
|
@auvipy still waiting for getting an answer for your reasoning. |
|
@alaminopu can you please check this report celery/kombu#2406 ? |
Yes, I will take a look this weekend. |
Description
Add support credential_provider to Redis Backend
Fixes #8505