Skip to content

Conversation

@Nusnus
Copy link
Member

@Nusnus Nusnus commented Aug 9, 2025

No description provided.

@Nusnus Nusnus self-assigned this Aug 9, 2025
@codecov
Copy link

codecov bot commented Aug 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.63%. Comparing base (33eb148) to head (c169268).
⚠️ Report is 71 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9855   +/-   ##
=======================================
  Coverage   78.63%   78.63%           
=======================================
  Files         153      153           
  Lines       19198    19198           
  Branches     2546     2546           
=======================================
  Hits        15096    15096           
- Misses       3807     3809    +2     
+ Partials      295      293    -2     
Flag Coverage Δ
unittests 78.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Nusnus Nusnus force-pushed the cifix branch 3 times, most recently from e98f537 to 2c7c397 Compare August 9, 2025 22:41
Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wah only 3 failures! I guess we can now focus on the remaining pr

@auvipy auvipy added this to the 5.6.0 milestone Aug 10, 2025
Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only one test is failing now

@Nusnus
Copy link
Member Author

Nusnus commented Aug 11, 2025

only one test is failing now

Yeah but I had to rerun many times.
I'm trying to find the source, I'm suspecting something with Redis but I'm still not sure.

I'll keep investigating bro, LMK if you have any idea/tip!

@auvipy
Copy link
Member

auvipy commented Aug 11, 2025

could be redis multi threading or race condition issue or this could be in billiard or may be not. #9837 (comment)

@Nusnus Nusnus force-pushed the cifix branch 4 times, most recently from a060103 to 6926cec Compare August 12, 2025 22:21
@auvipy
Copy link
Member

auvipy commented Aug 13, 2025

only one old known test is failing ::test_chain::test_chain_error_handler_with_eta PASSED
t/integration/test_canvas.py::test_chain::test_groupresult_serialization +++++++++++++++++++++++++++++++++++ Timeout ++++++++++++++++++++++++++++++++++++

  File "/opt/hostedtoolcache/Python/3.9.21/x64/lib/python3.9/threading.py", line 937, in _bootstrap
    self._bootstrap_inner()
  File "/opt/hostedtoolcache/Python/3.9.21/x64/lib/python3.9/threading.py", line 980, in _bootstrap_inner
    self.run()
  File "/opt/hostedtoolcache/Python/3.9.21/x64/lib/python3.9/threading.py", line 917, in run
    self._target(*self._args, **self._kwargs)
  File "/home/runner/_work/celery/celery/celery/contrib/testing/worker.py", line 77, in start
    return super().start()
  File "/home/runner/_work/celery/celery/celery/worker/worker.py", line 203, in start
    self.blueprint.start(self)
  File "/home/runner/_work/celery/celery/celery/bootsteps.py", line 116, in start
    step.start(parent)
  File "/home/runner/_work/celery/celery/celery/bootsteps.py", line 365, in start
    return self.obj.start()
  File "/home/runner/_work/celery/celery/celery/worker/consumer/consumer.py", line 341, in start
    blueprint.start(self)
  File "/home/runner/_work/celery/celery/celery/bootsteps.py", line 116, in start
    step.start(parent)
  File "/home/runner/_work/celery/celery/celery/worker/consumer/consumer.py", line 772, in start
    c.loop(*c.loop_args())
  File "/home/runner/_work/celery/celery/celery/worker/loops.py", line 97, in asynloop
    next(loop)
  File "/home/runner/_work/celery/celery/.tox/3.9-integration-redis/lib/python3.9/site-packages/kombu/asynchronous/hub.py", line 317, in create_loop
    events = poll(poll_timeout)
  File "/home/runner/_work/celery/celery/.tox/3.9-integration-redis/lib/python3.9/site-packages/kombu/utils/eventio.py", line 83, in poll
    return self._epoll.poll(timeout if timeout is not None else -1)
~~~~~~~~~~~~~~~~~~~~~ Stack of Thread-1 (139766358075072) ~~~~~~~~~~~~~~~~~~~~~~
  File "/opt/hostedtoolcache/Python/3.9.21/x64/lib/python3.9/threading.py", line 937, in _bootstrap
    self._bootstrap_inner()
  File "/opt/hostedtoolcache/Python/3.9.21/x64/lib/python3.9/threading.py", line 980, in _bootstrap_inner
    self.run()
  File "/opt/hostedtoolcache/Python/3.9.21/x64/lib/python3.9/threading.py", line 917, in run
    self._target(*self._args, **self._kwargs)
  File "/opt/hostedtoolcache/Python/3.9.21/x64/lib/python3.9/logging/handlers.py", line 1537, in _monitor
    record = self.dequeue(True)
  File "/opt/hostedtoolcache/Python/3.9.21/x64/lib/python3.9/logging/handlers.py", line 1486, in dequeue
    return self.queue.get(block)
  File "/home/runner/_work/celery/celery/.tox/3.9-integration-redis/lib/python3.9/site-packages/billiard/queues.py", line 99, in get
    res = self._recv_bytes()
  File "/home/runner/_work/celery/celery/.tox/3.9-integration-redis/lib/python3.9/site-packages/billiard/connection.py", line 240, in recv_bytes
    buf = self._recv_bytes(maxlength)
  File "/home/runner/_work/celery/celery/.tox/3.9-integration-redis/lib/python3.9/site-packages/billiard/connection.py", line 453, in _recv_bytes
    buf = self._recv(4)
  File "/home/runner/_work/celery/celery/.tox/3.9-integration-redis/lib/python3.9/site-packages/billiard/connection.py", line 419, in _recv
    chunk = read(handle, remaining)
+++++++++++++++++++++++++++++++++++ Timeout ++++++++++++++++++++++++++++++++++++
Error: Final attempt failed. Timeout of 900000ms hit

@Nusnus
Copy link
Member Author

Nusnus commented Aug 13, 2025

only one old known test is failing ::test_chain::test_chain_error_handler_with_eta PASSED t/integration/test_canvas.py::test_chain::test_groupresult_serialization +++++++++++++++++++++++++++++++++++ Timeout ++++++++++++++++++++++++++++++++++++

  File "/opt/hostedtoolcache/Python/3.9.21/x64/lib/python3.9/threading.py", line 937, in _bootstrap
    self._bootstrap_inner()
  File "/opt/hostedtoolcache/Python/3.9.21/x64/lib/python3.9/threading.py", line 980, in _bootstrap_inner
    self.run()
  File "/opt/hostedtoolcache/Python/3.9.21/x64/lib/python3.9/threading.py", line 917, in run
    self._target(*self._args, **self._kwargs)
  File "/home/runner/_work/celery/celery/celery/contrib/testing/worker.py", line 77, in start
    return super().start()
  File "/home/runner/_work/celery/celery/celery/worker/worker.py", line 203, in start
    self.blueprint.start(self)
  File "/home/runner/_work/celery/celery/celery/bootsteps.py", line 116, in start
    step.start(parent)
  File "/home/runner/_work/celery/celery/celery/bootsteps.py", line 365, in start
    return self.obj.start()
  File "/home/runner/_work/celery/celery/celery/worker/consumer/consumer.py", line 341, in start
    blueprint.start(self)
  File "/home/runner/_work/celery/celery/celery/bootsteps.py", line 116, in start
    step.start(parent)
  File "/home/runner/_work/celery/celery/celery/worker/consumer/consumer.py", line 772, in start
    c.loop(*c.loop_args())
  File "/home/runner/_work/celery/celery/celery/worker/loops.py", line 97, in asynloop
    next(loop)
  File "/home/runner/_work/celery/celery/.tox/3.9-integration-redis/lib/python3.9/site-packages/kombu/asynchronous/hub.py", line 317, in create_loop
    events = poll(poll_timeout)
  File "/home/runner/_work/celery/celery/.tox/3.9-integration-redis/lib/python3.9/site-packages/kombu/utils/eventio.py", line 83, in poll
    return self._epoll.poll(timeout if timeout is not None else -1)
~~~~~~~~~~~~~~~~~~~~~ Stack of Thread-1 (139766358075072) ~~~~~~~~~~~~~~~~~~~~~~
  File "/opt/hostedtoolcache/Python/3.9.21/x64/lib/python3.9/threading.py", line 937, in _bootstrap
    self._bootstrap_inner()
  File "/opt/hostedtoolcache/Python/3.9.21/x64/lib/python3.9/threading.py", line 980, in _bootstrap_inner
    self.run()
  File "/opt/hostedtoolcache/Python/3.9.21/x64/lib/python3.9/threading.py", line 917, in run
    self._target(*self._args, **self._kwargs)
  File "/opt/hostedtoolcache/Python/3.9.21/x64/lib/python3.9/logging/handlers.py", line 1537, in _monitor
    record = self.dequeue(True)
  File "/opt/hostedtoolcache/Python/3.9.21/x64/lib/python3.9/logging/handlers.py", line 1486, in dequeue
    return self.queue.get(block)
  File "/home/runner/_work/celery/celery/.tox/3.9-integration-redis/lib/python3.9/site-packages/billiard/queues.py", line 99, in get
    res = self._recv_bytes()
  File "/home/runner/_work/celery/celery/.tox/3.9-integration-redis/lib/python3.9/site-packages/billiard/connection.py", line 240, in recv_bytes
    buf = self._recv_bytes(maxlength)
  File "/home/runner/_work/celery/celery/.tox/3.9-integration-redis/lib/python3.9/site-packages/billiard/connection.py", line 453, in _recv_bytes
    buf = self._recv(4)
  File "/home/runner/_work/celery/celery/.tox/3.9-integration-redis/lib/python3.9/site-packages/billiard/connection.py", line 419, in _recv
    chunk = read(handle, remaining)
+++++++++++++++++++++++++++++++++++ Timeout ++++++++++++++++++++++++++++++++++++
Error: Final attempt failed. Timeout of 900000ms hit

Almost there!
Hehe..

@Nusnus Nusnus force-pushed the cifix branch 3 times, most recently from 5165dd0 to 05b10e9 Compare August 13, 2025 17:35
@Nusnus Nusnus changed the title Refactor integration tests CI Refactor integration and smoke tests CI Aug 25, 2025
@Nusnus Nusnus marked this pull request as ready for review August 26, 2025 01:00
@Nusnus Nusnus merged commit 777d92f into celery:main Aug 26, 2025
199 of 203 checks passed
@Nusnus Nusnus deleted the cifix branch August 26, 2025 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants