chore(ci): Enhance CI with workflow_dispatch for targeted debugging and testing (#8822)#8826
Merged
Nusnus merged 2 commits intocelery:mainfrom Jan 30, 2024
Merged
Conversation
Nusnus
reviewed
Jan 30, 2024
… and testing (celery#8822) This patch introduces `workflow_dispatch` trigger into CI, to allow for more manual and targeted control of running independent pipelines during CI debugging or test environments. A solution to help developers run isolated workflows from their CLI, in case of failure. At the moment, the implmentation respects strong defaults according to the events documentation: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#providing-inputs
440a7b0 to
7c8772e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8826 +/- ##
==========================================
- Coverage 81.25% 81.25% -0.01%
==========================================
Files 149 149
Lines 18553 18553
Branches 3166 3166
==========================================
- Hits 15076 15075 -1
Misses 3191 3191
- Partials 286 287 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
At this point the runners are stressed, give it some break and rerun failing workflows - should pass!
|
Member
Exception ignored in: <function AsyncResult.__del__ at 0x7f8a63cf4040>
Traceback (most recent call last):
File "/home/runner/work/celery/celery/celery/result.py", line 417, in __del__
self.backend.remove_pending_result(self)
File "/home/runner/work/celery/celery/celery/backends/asynchronous.py", line 208, in remove_pending_result
self.on_result_fulfilled(result)
File "/home/runner/work/celery/celery/celery/backends/asynchronous.py", line 216, in on_result_fulfilled
self.result_consumer.cancel_for(result.id)
File "/home/runner/work/celery/celery/celery/backends/redis.py", line 184, in cancel_for
self._pubsub.unsubscribe(key)
File "/opt/hostedtoolcache/Python/3.9.18/x64/lib/python3.9/contextlib.py", line 137, in __exit__
self.gen.throw(typ, value, traceback)
File "/home/runner/work/celery/celery/celery/backends/redis.py", line 130, in reconnect_on_error
self._ensure(self._reconnect_pubsub, ())
File "/home/runner/work/celery/celery/celery/backends/redis.py", line 384, in ensure
return retry_over_time(
File "/home/runner/work/celery/celery/.tox/3.9-smoke/lib/python3.9/site-packages/kombu/utils/functional.py", line 318, in retry_over_time
return fun(*args, **kwargs)
File "/home/runner/work/celery/celery/celery/backends/redis.py", line 117, in _reconnect_pubsub
self._pubsub.connection = self._pubsub.connection_pool.get_connection(
File "/home/runner/work/celery/celery/.tox/3.9-smoke/lib/python3.9/site-packages/redis/connection.py", line 1086, in get_connection
connection.connect()
File "/home/runner/work/celery/celery/.tox/3.9-smoke/lib/python3.9/site-packages/redis/connection.py", line 270, in connect
raise ConnectionError(self._error_message(e))
redis.exceptions.ConnectionError: Error 111 connecting to localhost:32882. Connection refused.When the smoke tests start hanging its due to some instability with the Redis container. But this PR is as good as merged. |
Nusnus
approved these changes
Jan 30, 2024
Member
|
@50-Course as an Admin I am not sure this affects my UI. Maybe after rebasing on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This patch introduces
workflow_dispatchtrigger into CI, to allow for more manual and targeted control of running independent pipelines during CI debugging or test environments.A solution to help developers run isolated workflows from their CLI, in case of failure.
At the moment, the implementation respects strong defaults according to the events documentation
Fixes #8822