Deprecate parse_iso8601 in favor of fromisoformat#8098
Merged
auvipy merged 1 commit intocelery:mainfrom Mar 3, 2023
stumpylog:main
Merged
Deprecate parse_iso8601 in favor of fromisoformat#8098auvipy merged 1 commit intocelery:mainfrom stumpylog:main
auvipy merged 1 commit intocelery:mainfrom
stumpylog:main
Conversation
auvipy
reviewed
Mar 3, 2023
|
|
||
| def parse_iso8601(datestring): | ||
| """Parse and convert ISO-8601 string to datetime.""" | ||
| warn("parse_iso8601", "v5.3", "v6", "datetime.datetime.fromisoformat") |
Member
There was a problem hiding this comment.
is this raising warning properly?
Contributor
Author
There was a problem hiding this comment.
In used what I found built in. The parameter depracation is provided, so the final result is a warnings.warn with a CDeprecationWarning. So yes, I believe so.
auvipy
approved these changes
Mar 3, 2023
18 tasks
Member
|
hey! we got a bug report issue #8499 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Before submitting this pull request, please review our contributing
guidelines.
Description
Fixes #8080. As suggested there, marks as deprecated for v5.3 with removal planned in v6