Skip to content

Add --skip-checks flag to bypass django core checks#7859

Merged
auvipy merged 1 commit intocelery:masterfrom
mudetz:master
Nov 3, 2022
Merged

Add --skip-checks flag to bypass django core checks#7859
auvipy merged 1 commit intocelery:masterfrom
mudetz:master

Conversation

@mudetz
Copy link
Copy Markdown
Contributor

@mudetz mudetz commented Oct 28, 2022

Description

Resolves feature request #7581

@auvipy auvipy added this to the 5.3 milestone Oct 29, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 29, 2022

Codecov Report

Base: 89.59% // Head: 89.59% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (fdd1439) compared to base (5092598).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7859   +/-   ##
=======================================
  Coverage   89.59%   89.59%           
=======================================
  Files         128      128           
  Lines       15849    15855    +6     
  Branches     2132     2134    +2     
=======================================
+ Hits        14200    14206    +6     
  Misses       1413     1413           
  Partials      236      236           
Flag Coverage Δ
unittests 89.58% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
celery/fixups/django.py 93.89% <100.00%> (+0.04%) ⬆️
celery/canvas.py 94.41% <0.00%> (+0.01%) ⬆️
celery/app/task.py 95.02% <0.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mudetz mudetz requested a review from auvipy November 2, 2022 17:00
@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Nov 2, 2022

This pull request fixes 1 alert when merging fdd1439 into be1d3c0 - view on LGTM.com

fixed alerts:

  • 1 for Non-exception in 'except' clause

Copy link
Copy Markdown
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should have this new command flag documented here
https://docs.celeryq.dev/en/stable/reference/cli.html or look for appropriate place to describe the new command with versionadded 5.3 notation

@mudetz
Copy link
Copy Markdown
Contributor Author

mudetz commented Nov 3, 2022

we should have this new command flag documented here https://docs.celeryq.dev/en/stable/reference/cli.html or look for appropriate place to describe the new command with versionadded 5.3 notation

It is documented automatically in the CLI reference: https://celery--7859.org.readthedocs.build/en/7859/reference/cli.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants