Add type annotation on concurrency/threads.py#7808
Add type annotation on concurrency/threads.py#7808auvipy merged 2 commits intocelery:masterfrom Kludex:typing/concurrency/threads
concurrency/threads.py#7808Conversation
Kludex
commented
Oct 15, 2022
- Related to Plan to annotate Celery #7394
| # TODO use a public api to retrieve the current number of threads | ||
| # in the executor when available. (Currently not available). |
There was a problem hiding this comment.
This will never happen.
Codecov ReportBase: 89.59% // Head: 89.55% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #7808 +/- ##
==========================================
- Coverage 89.59% 89.55% -0.04%
==========================================
Files 128 128
Lines 15877 15888 +11
Branches 2117 2119 +2
==========================================
+ Hits 14225 14229 +4
- Misses 1423 1429 +6
- Partials 229 230 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
|
||
| __all__ = ('TaskPool',) | ||
|
|
||
| if TYPE_CHECKING: |
There was a problem hiding this comment.
Everything inside this block should have been ignored by codecov, according to
Line 25 in 651095e
Why isn't?
There was a problem hiding this comment.
the config is of pre mypy era of celery, so we can adjust that
There was a problem hiding this comment.
I don't know what needs to be adjusted on codecov. 👀
There was a problem hiding this comment.
Do you want me to open a PR removing it, and calculate the coverage exclusively with coverage?
There was a problem hiding this comment.
I saw some projects moved to that, you can come with that
|
@auvipy anything else that I can do for this PR? I can clarify anything needed here. |