Annotate celery/security#7401
Annotate celery/security#7401Kludex wants to merge 6 commits intocelery:mainfrom Kludex:annotate/security
celery/security#7401Conversation
|
This pull request introduces 1 alert and fixes 2 when merging cd70b68 into 1ccd887 - view on LGTM.com new alerts:
fixed alerts:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7401 +/- ##
==========================================
- Coverage 89.30% 89.18% -0.12%
==========================================
Files 138 138
Lines 16762 16790 +28
Branches 2451 2458 +7
==========================================
+ Hits 14969 14974 +5
- Misses 1561 1580 +19
- Partials 232 236 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| else: | ||
| from typing import Literal | ||
|
|
||
| _Serializer = Literal["json", "msgpack", "yaml", "pickle"] |
There was a problem hiding this comment.
Here is kind of tricky, because the user can also add custom serializers. Meaning that the annotation should be str instead. I'm open to change it.
Also, not related, but I have two _Serializer in this PR, on different files. I accept suggestion on where to put them, if duplicated is not wanted.
|
This pull request fixes 2 alerts when merging 22a231e into 1ccd887 - view on LGTM.com fixed alerts:
|
I had to remove
utils.pyandserialization.pyfrom themypyfiles, as there are somemypyerrors that are sensitive i.e. I'd need to implement further changes (which can be considered breaking changes). I don't want to implement breaking changes on annotation PRs, so I'll open separate ones later on. If you want to know which are the sensitive ones I'm mentioning, you just need to add those two files on thepyproject.toml, and you'll understand the changes that are needed.