Annotate celery/security/certificate.py#7398
Annotate celery/security/certificate.py#7398auvipy merged 6 commits intocelery:mainfrom Kludex:annotate/celery/security/certificate.py
celery/security/certificate.py#7398Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #7398 +/- ##
=======================================
Coverage 87.01% 87.01%
=======================================
Files 148 148
Lines 18442 18444 +2
Branches 2515 2515
=======================================
+ Hits 16047 16049 +2
+ Misses 2118 2117 -1
- Partials 277 278 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
auvipy
left a comment
There was a problem hiding this comment.
please rebase & would be great if some unit test coverage can be increased
|
This pull request introduces 1 alert when merging e1353ec into 1ccd887 - view on LGTM.com new alerts:
|
|
This pull request introduces 2 alerts when merging 6d90890 into ae20aa9 - view on LGTM.com new alerts:
|
|
Hey @Kludex , Would you mind pushing this forward? Thanks! |
|
What is missing? Rebase? |
|
a re base should be OK |
I believe that's all my friend |
Co-authored-by: Omer Katz <omer.katz@omerkatz.com>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
Done 👍 |
|
Thanks for closing this! 💯 |
I've disabled
warn_return_any, as it was not intended to be included in the configuration. Also, there are some issues with it: python/mypy#5697. In this file, there were some comparison (__eq__and__gt__) that caused the issue.