Annotate celery/states.py#7395
Merged
auvipy merged 3 commits intocelery:masterfrom Apr 3, 2022
Kludex:annotate/celery/states.py
Merged
Annotate celery/states.py#7395auvipy merged 3 commits intocelery:masterfrom Kludex:annotate/celery/states.py
celery/states.py#7395auvipy merged 3 commits intocelery:masterfrom
Kludex:annotate/celery/states.py
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7395 +/- ##
=======================================
Coverage 89.30% 89.30%
=======================================
Files 138 138
Lines 16762 16762
Branches 2451 2451
=======================================
Hits 14969 14969
Misses 1561 1561
Partials 232 232
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
auvipy
approved these changes
Apr 3, 2022
Member
auvipy
left a comment
There was a problem hiding this comment.
is there any better ways to validate or verify type hints?
Contributor
Author
I'm not sure if I get the question. Isn't mypy doing that for us already? |
Member
|
also to avoid to much small PR, can you include small modules type hints in a single PR? with separate commits? |
Contributor
Author
|
Sure! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EDIT: I've included
celery/signals.pyon this PR, as there was no changes needed on it.