Codecov Report

Patch and project coverage have no change.

Comparison is base (d34146f) 87.16% compared to head (a508f37) 87.16%.

@@           Coverage Diff           @@
##             main    #7069   +/-   ##
=======================================
  Coverage   87.16%   87.16%           
=======================================
  Files         148      148           
  Lines       18469    18469           
  Branches     2524     2524           
=======================================
  Hits        16098    16098           
  Misses       2091     2091           
  Partials      280      280           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hannseman what do think about my thoughts on windows build

@auvipy I'm not that familiar with working on Python stuff in Windows but it looks like pycurl should have wheels for Windows so it should be installable. The error I'm looking at is this one:

  Collecting pycurl~=7.44.1
131
    Downloading pycurl-7.44.1.tar.gz (227 kB)
132
    Preparing metadata (setup.py): started
133
    Preparing metadata (setup.py): finished with status 'error'
134
    ERROR: Command errored out with exit status 10:
135
     command: 'D:\a\celery\celery\.tox\3.8-unit\Scripts\python.EXE' -c 'import io, os, sys, setuptools, tokenize; sys.argv[0] = '"'"'C:\\Users\\runneradmin\\AppData\\Local\\Temp\\pip-install-innclb3y\\pycurl_875358ca3df246c5b05c8fef321401cb\\setup.py'"'"'; __file__='"'"'C:\\Users\\runneradmin\\AppData\\Local\\Temp\\pip-install-innclb3y\\pycurl_875358ca3df246c5b05c8fef321401cb\\setup.py'"'"';f = getattr(tokenize, '"'"'open'"'"', open)(__file__) if os.path.exists(__file__) else io.StringIO('"'"'from setuptools import setup; setup()'"'"');code = f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base 'C:\Users\runneradmin\AppData\Local\Temp\pip-pip-egg-info-cy3b6h_w'
136
         cwd: C:\Users\runneradmin\AppData\Local\Temp\pip-install-innclb3y\pycurl_875358ca3df246c5b05c8fef321401cb\
137
    Complete output (1 lines):
138
    Please specify --curl-dir=/path/to/built/libcurl
139

From https://github.com/celery/celery/runs/4165002584?check_suite_focus=true

It looks like the 7.44.1 does not have any wheels, the latest one I can find which do is 7.43.05 (https://pypi.org/project/pycurl/7.43.0.5/#files). Also see this issue pycurl/pycurl#710.

we officially don't support windows so we are safe on that. I have also added a comment there to release a wheel for latest release

we officially don't support windows so we are safe on that. I have also added a comment there to release a wheel for latest release

Looks like there's no immediate plan to bring back wheels to pycurl, see pycurl/pycurl#657

If the intention is to drop the pin of pycurl to the wheeled version (as already done in kombu) one could look into specifying --curl-dir on windows runs in CI. See https://github.com/pycurl/pycurl/blob/master/INSTALL.rst#windows

@graingert we don't support windows 32 bit should we follow the --curl-dir path for windows build for latest pycurl release?

couchbase>=3.0.0; platform_python_implementation!='PyPy' and (platform_system != 'Windows' or python_version < '3.10') --- got this and will adjust accordingly