Skip to content

fix: node_format() logfile before detaching#6488

Merged
auvipy merged 1 commit intomasterfrom
fix/node_format-detached-logfiles
Nov 19, 2020
Merged

fix: node_format() logfile before detaching#6488
auvipy merged 1 commit intomasterfrom
fix/node_format-detached-logfiles

Conversation

@maybe-sybr
Copy link
Contributor

Fixes #6426

@maybe-sybr
Copy link
Contributor Author

As an interesting note, we don't node_format(pidfile) when we detach vs when we remain attached. But pidfile names seem to work as expected anyway so presumably that formatting is happening somewhere. A %n in the pidfile argument gets handled by the multi runner, but then if I add a %I, it gets mysteriously handled somewhere on the way to being used to drop the actual pidfile once the multiple workers get started. Probably not an issue.

Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you check why pypy tests are failing?

@maybe-sybr
Copy link
Contributor Author

maybe-sybr commented Nov 18, 2020

can you check why pypy tests are failing?

That failure is unrelated.
@auvipy @maybe-sybr Can you please open an issue so we'll eventually investigate this?

#6489 @thedrow . I also just re-ran the travis actions.

@auvipy auvipy merged commit 60ba379 into master Nov 19, 2020
@auvipy auvipy deleted the fix/node_format-detached-logfiles branch November 19, 2020 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

celery multicreates xxx_%I.log files

2 participants