Skip to content

bugfix: when set config result_expires = 0, chord.get will hang.#6373

Merged
thedrow merged 3 commits intocelery:masterfrom
laixintao:bugfix/chord-expire
Sep 30, 2020
Merged

bugfix: when set config result_expires = 0, chord.get will hang.#6373
thedrow merged 3 commits intocelery:masterfrom
laixintao:bugfix/chord-expire

Conversation

@laixintao
Copy link
Contributor

@laixintao laixintao commented Sep 29, 2020

EXPIRE key 0 will delete a key in redis, then chord will never get the
result.

fix: #5237

Description

From the doc:

A value of None or 0 means results will never expire (depending on backend specifications).

https://docs.celeryproject.org/en/stable/userguide/configuration.html#std-setting-result_expires

But here only checked with None, 0 was missed.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chord callback method can not execute when result_expires =0 or None

2 participants