Skip to content

Make tests compatible with pymongo >= 4.16#10074

Merged
auvipy merged 2 commits intocelery:mainfrom
cjwatson:pymongo-4.16
Feb 4, 2026
Merged

Make tests compatible with pymongo >= 4.16#10074
auvipy merged 2 commits intocelery:mainfrom
cjwatson:pymongo-4.16

Conversation

@cjwatson
Copy link
Contributor

Description

InvalidDocument now requires a message argument (following mongodb/mongo-python-driver#2539); it was previously optional.

`InvalidDocument` now requires a `message` argument; it was previously
optional.
@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.50%. Comparing base (bb6b484) to head (816789e).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10074   +/-   ##
=======================================
  Coverage   87.50%   87.50%           
=======================================
  Files         153      153           
  Lines       19374    19374           
  Branches     2228     2228           
=======================================
  Hits        16953    16953           
  Misses       2125     2125           
  Partials      296      296           
Flag Coverage Δ
unittests 87.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@auvipy auvipy added this to the 5.7.0 milestone Jan 28, 2026
@auvipy auvipy self-requested a review January 28, 2026 05:55
Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you mind doing the same for kombu as well?

@cjwatson
Copy link
Contributor Author

kombu has no references to InvalidDocument, and it seems to pass its tests with pymongo 4.16, so I can't think of anything to do there. (And I think the versions in its requirements should probably only be bumped once that won't break celery.)

@auvipy auvipy merged commit ec4a557 into celery:main Feb 4, 2026
16 of 17 checks passed
@cjwatson cjwatson deleted the pymongo-4.16 branch February 4, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants