-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Closed
Labels
Milestone
Description
Checklist
- I have verified that the issue exists against the
masterbranch of Celery. - This has already been asked to the discussion group first.
- I have read the relevant section in the
contribution guide
on reporting bugs. - I have checked the issues list
for similar or identical bug reports. - I have checked the pull requests list
for existing proposed fixes. - I have checked the commit log
to find out if the bug was already fixed in the master branch. - I have included all related issues and possible duplicate issues
in this issue (If there are none, check this box anyway).
Mandatory Debugging Information
- I have included the output of
celery -A proj reportin the issue.
(if you are not able to do this, then at least specify the Celery
version affected). - I have verified that the issue exists against the
masterbranch of Celery. - I have included the contents of
pip freezein the issue. - I have included all the versions of all the external dependencies required
to reproduce this bug.
Optional Debugging Information
- I have tried reproducing the issue on more than one Python version
and/or implementation. - I have tried reproducing the issue on more than one message broker and/or
result backend. - I have tried reproducing the issue on more than one version of the message
broker and/or result backend. - I have tried reproducing the issue on more than one operating system.
- I have tried reproducing the issue on more than one workers pool.
- I have tried reproducing the issue with autoscaling, retries,
ETA/Countdown & rate limits disabled. - I have tried reproducing the issue after downgrading
and/or upgrading Celery and its dependencies.
Related Issues and Possible Duplicates
Related Issues
- added retry_on_timeout and socket_keepalive to redis connection #5952
- Calling a task returns a TypeError in 3.1.19 with redis as a broker. #2903
Possible Duplicates
- None
Environment & Settings
Celery version: 4.4.1
Steps to Reproduce
Required Dependencies
Python Packages
pip freeze Output:
``` redis==3.4.1 billiard==3.6.3.0 celery==4.4.1 kombu==4.6.8 ```
Other Dependencies
Details
N/A
Minimally Reproducible Test Case
Details
Expected Behavior
Celery just works
Actual Behavior
After upgrading Celery from 4.4.0 to 4.4.1 I suddenly see TypeError: __init__() got an unexpected keyword argument 'socket_keepalive'.
This seems to be caused by PR #5952, which adds this kwarg for Redis connections. However, not all Redis connection constructors take the same arguments (e.g. UnixDomainSocketConnection doesn't take socket_keepalive). This seems to be happened before as noted in issue #2903.
Everything works fine if I downgrade to 4.4.0 again.