-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Closed
Milestone
Description
Checklist
- I have checked the issues list
for similar or identical feature requests. - I have checked the pull requests list
for existing proposed implementations of this feature. - I have checked the commit log
to find out if the if the same feature was already implemented in the
master branch. - I have included all related issues and possible duplicate issues
in this issue (If there are none, check this box anyway).
Related Issues and Possible Duplicates
Related Issues
- None
Possible Duplicates
- None
Description
I was trying to change config of Redis backend connections (not Kombu broker_transport_options).
This is not a problem for socket_timeout and socket_connect_timeout (I've set CELERY_REDIS_SOCKET_TIMEOUT and CELERY_REDIS_SOCKET_CONNECT_TIMEOUT), but problem to change socket_keepalive and retry_on_timeout.
I think this can be helpful - sometimes I catching TimeoutError from Beat on 'SUBSCRIBE' event.
Suggestions
I propose add socket_keepalive and retry_on_timeout to connparams of RedisBackend:
celery/celery/backends/redis.py
Lines 185 to 194 in 240ef1f
| self.connparams = { | |
| 'host': _get('redis_host') or 'localhost', | |
| 'port': _get('redis_port') or 6379, | |
| 'db': _get('redis_db') or 0, | |
| 'password': _get('redis_password'), | |
| 'max_connections': self.max_connections, | |
| 'socket_timeout': socket_timeout and float(socket_timeout), | |
| 'socket_connect_timeout': | |
| socket_connect_timeout and float(socket_connect_timeout), | |
| } |
Metadata
Metadata
Assignees
Labels
No labels