#296 Add job id to WorkerLostError message #317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auvipy
requested changes
Jul 12, 2020
Member
auvipy
left a comment
There was a problem hiding this comment.
thanks for the patch, is the pypy 2.7 failure unrelated?
Contributor
Author
|
@auvipy, |
Member
|
can we pin psutils for now? |
Contributor
Author
|
@auvipy Apologies for the delay. I've pinned psutil to the last known good version for pypy2 and added a message to clarify why it's pinned. This should be good to review now |
auvipy
approved these changes
Jul 26, 2020
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket Id: #296
This adds a job id to the WorkerLostError error message so that it's easier to figure out which job was killed with a worker lost.
Alternatively, if you don't want to change the exception message I can add this as a separate debug message