fix: TemplateExecutor fixed attributes#37
Merged
marioscrock merged 2 commits intomainfrom Mar 12, 2025
Merged
Conversation
TemplateFunctions and TemplateMap should be provided for each mapping application, as they could be changed (TemplateMap) or could contain stateful logic (TemplateFunctions)
marioscrock
requested changes
Mar 10, 2025
| TemplateExecutor templateExecutor = new TemplateExecutor(new TemplateFunctions(), true, false, false, null, null); | ||
| String result = templateExecutor.executeMapping(readers, template).replaceAll("\\r\\n", "\n");; | ||
| TemplateExecutor templateExecutor = new TemplateExecutor( true, false, false, null); | ||
| String result = templateExecutor.executeMapping(readers, template, new TemplateFunctions(), null).replaceAll("\\r\\n", "\n");; |
Member
There was a problem hiding this comment.
I would keep a method .executeMapping(readers, template) that automatically calls .executeMapping(readers, template, new TemplateFunctions(), null) since in most of the cases only the default utils without a Map are used
marioscrock
approved these changes
Mar 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TemplateFunctions and TemplateMap should be provided for each mapping execution, as they could be changed (TemplateMap) or could contain stateful logic (TemplateFunctions).
Closes #35, #36.