Skip to content
This repository was archived by the owner on Jul 16, 2023. It is now read-only.

Upload non-minified version to npm#59

Merged
cee-chen merged 1 commit intocee-chen:masterfrom
ajlende:patch-1
Jan 22, 2021
Merged

Upload non-minified version to npm#59
cee-chen merged 1 commit intocee-chen:masterfrom
ajlende:patch-1

Conversation

@ajlende
Copy link
Copy Markdown
Contributor

@ajlende ajlende commented Jan 21, 2021

I found this polyfill when working on WordPress/gutenberg. However, plugins must include a (mostly) human readable version of the code. Uploading the src folder to npm would allow us to use it.

@ajlende ajlende mentioned this pull request Jan 21, 2021
Merged
10 tasks
@noisysocks noisysocks mentioned this pull request Jan 22, 2021
Closed
6 tasks
@cee-chen
Copy link
Copy Markdown
Owner

cee-chen commented Jan 22, 2021

Ahhh I hadn't realized, thanks so much! Here I was thinking I was trying to save some bytes 🤦‍♀️ The security concern totally makes sense though. Thanks!

@cee-chen cee-chen merged commit 283770c into cee-chen:master Jan 22, 2021
@cee-chen
Copy link
Copy Markdown
Owner

cee-chen commented Jan 22, 2021 •
edited
Loading

Also privately I am TOTALLY over the moon that my small polyfill will be used by WordPress 😄 To be honest I wasn't really sure it'd be of huge use after Edge switched to webkit. Super cool, and definitely reach out if y'all need any further updates and I should get off my butt!

@noisysocks
Copy link
Copy Markdown

noisysocks commented Jan 27, 2021

Thanks for merging this @constancecchen! Could you please publish a new release to npm so that when I npm install objectFitPolyfill I get the src folder in my node_modules?

@cee-chen
Copy link
Copy Markdown
Owner

cee-chen commented Jan 27, 2021

Ah yes, apologies!! 🤦‍♀️ I should have just done so here, please let me know if you have any issues with the published package. Also don't hesitate to keep prodding me about things like this!

@noisysocks
Copy link
Copy Markdown

noisysocks commented Jan 27, 2021

Thank you! Shall do 🙂

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ajlende @cee-chen @noisysocks