Merged
Conversation
egonw
requested changes
May 10, 2023
|
|
||
| ## Acknowledgments | ||
|
|
||
|  |
Member
There was a problem hiding this comment.
You can leave this out. Unless you used it too.
|
|
||
| ```xml | ||
| <dependency> | ||
| <artifactId>cdk-bundle</artifactId> |
Member
There was a problem hiding this comment.
I don't think you need this. When you depend on cdk-scaffold it will bring in all the needed CDK modules already. Adding this one means that people download a lot of libraries that they may never be using.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comments very welcome! I tried to adapt the CDK repo readme as well as possible.