Fix a stuble corner case. When we split a molecule we now update the …#852
Merged
Fix a stuble corner case. When we split a molecule we now update the …#852
Conversation
…Sgroups accordingly. If an sgroups spans multiple components (e.g. a mixture bracket) we now delete it since it is redundant or inconsistent (the other option would be to add it to all parts it occurs in). To make things work nicely we should leave the original Sgroups intact.
|
Kudos, SonarCloud Quality Gate passed! |
Member
Author
|
subtle even... not sure why builds are failing |
Member
|
I reran the build with J8 and this time it worked. The error message suggested a time out, so I suspect a tmp DNS fail. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…Sgroups accordingly. If an sgroups spans multiple components (e.g. a mixture bracket) we now delete it since it is redundant or inconsistent (the other option would be to add it to all parts it occurs in). To make things work nicely we should leave the original Sgroups intact.