restore space as delimiter for string-based definition of InChI options#846
Merged
johnmay merged 2 commits intocdk:masterfrom Mar 7, 2022
Merged
restore space as delimiter for string-based definition of InChI options#846johnmay merged 2 commits intocdk:masterfrom
johnmay merged 2 commits intocdk:masterfrom
Conversation
Member
|
Thanks just running the tests but looks fine - I wonder if maybe it should be both String and Comma - it definitely used to be space though as I noted it was essentially like command line args. "-15T -KET" etc - annoyingly on Windows you needed to use "/15T /KET" |
Contributor
Author
Me too. I'm sending a new PR where one can use both comma and space. |
Contributor
Author
Actually, it's not a "new PR". I've committed the new changes to this same branch, so it already in this PR. |
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #845