Compute correct HuLuIndex values and add a test case for a closed bug…#832
Merged
Compute correct HuLuIndex values and add a test case for a closed bug…#832
Conversation
Member
Author
|
We closed #737 accidentally it seems - I remember there was some other bug with it though so managed to track it down. |
egonw
requested changes
Feb 9, 2022
| /* | ||
| * ===================================== | ||
| * Copyright (c) 2022 NextMove Software | ||
| * ===================================== |
Member
There was a problem hiding this comment.
Copyright NextMove is fine. Please use the common format with the license, tho.
Member
Author
There was a problem hiding this comment.
Yes sorry just the default in the IDE :-)
Member
|
@rajarshi, may I invite you to have a quick look at this patch too? |
egonw
approved these changes
Feb 9, 2022
rajarshi
reviewed
Feb 12, 2022
Member
rajarshi
left a comment
There was a problem hiding this comment.
Looks good - nothing obvious jumped out to me
Member
thanks! |
Member
Author
|
Will rebase |
d1c6005 to
ba422bd
Compare
Member
Author
|
Okay rebased - should be good but will wait for build |
|
Kudos, SonarCloud Quality Gate passed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… that still existed.
Fixes #737 and #830.