Conversation
…s added to a molecule it's atom/bond components are remapped to the internal AtomRef/BondRef of the molecule in question. This ensure any future actions such as swapping and atom for another work correctly. This is now more robust and we get an error if we try to add stereochemistry that includes atom/bonds not in this molecule - this makes sense.
… function in the structure diagram generator. This is a bit of a missue but reasonable - we now need check if the stereochemistry has not be split between two molecules. We should also do the same of Sgroups (issue openned).
|
SonarCloud Quality Gate failed. |
Member
Author
|
Hmm I thought I configured the quality gate to only fail if there was major bugs |
Member
|
I looked at the code, and always check the testing. Good to go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #812. This was quite a tricky one and very subtle. The minimal example is
*/C=C/C>> |$R$|, essentially due to AtomContainer2 AtomRef/BondRef the stereo gets in an inconsistent state. To handle these these implementations now remap stereo chemistry to their internal references when adding stereo.A side-effect is addStereo() is now more robust and so some tests needed updating. There was also a slight miss-use of the connected components in SDG (my own doing) to split a single molecule. In this case we need to check if we split in the middle of stereochemistry. This also exposes another issue with Sgroups which I will open an issue for.