Skip to content

Overflow logic was not quite correct. Restrict based on number of dig…#810

Merged
egonw merged 2 commits intomasterfrom
mf-double-overflow
Feb 1, 2022
Merged

Overflow logic was not quite correct. Restrict based on number of dig…#810
egonw merged 2 commits intomasterfrom
mf-double-overflow

Conversation

@johnmay
Copy link
Copy Markdown
Member

@johnmay johnmay commented Jan 31, 2022

…its, in base 10, 7 digits is enough for 9.9 million atoms which is more than enough for any molecule.

…its, in base 10, 7 digits is enough for 9.9 million atoms which is more than enough for any molecule.
@johnmay
Copy link
Copy Markdown
Member Author

johnmay commented Jan 31, 2022

See comment on #808

@johnmay
Copy link
Copy Markdown
Member Author

johnmay commented Feb 1, 2022

Fixed

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Feb 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@egonw egonw merged commit 1078174 into master Feb 1, 2022
@johnmay johnmay deleted the mf-double-overflow branch February 9, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants