Skip to content

Simplify the SybylAtomTypeMatcherTest.#1231

Merged
egonw merged 1 commit intomainfrom
sybyl-atomtype-tests
Sep 16, 2025
Merged

Simplify the SybylAtomTypeMatcherTest.#1231
egonw merged 1 commit intomainfrom
sybyl-atomtype-tests

Conversation

@johnmay
Copy link
Copy Markdown
Member

@johnmay johnmay commented Sep 15, 2025

  • Don't need the abstract super class
  • Avoiding reading Mol2 files (use direct input)

A bit like playing chess I am running package movement forwards and backwards to work out the sticky point.

These changes (and once cdk-core is unified) allow us to move it to cdk-atomtype/test along with the EStateMacherTest (currently in test-standard yet the code being tested in cdk-atomtype).

- Don't need the abstract super class
- Avoiding reading Mol2 files (use direct input)
@sonarqubecloud
Copy link
Copy Markdown

@egonw egonw merged commit 7772918 into main Sep 16, 2025
11 checks passed
@johnmay johnmay deleted the sybyl-atomtype-tests branch March 3, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants