fix issue with empty annotation in depiction#1214
Merged
Conversation
…ionTest; update StandardGenerator to skip empty annotation labels
…r in DepictionTest; simplify stream operations in DepictionTest; remove unused imports and redundant whitespace in StandardGenerator; minor code cleanup in StandardGenerator
Member
Author
|
afk for a week, so apologies for any delays in responding to questions here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without any code changes in the non-test space of the code
DepictionTest::testAtomPropertyEmptyStringAnnotationLabelfails:I looked through the stack trace and put in a simple check that prevents the
ArrayIndexOutOfBoundsException. However, I am not sure if this is the proper place to fix this.One could ask the question if it is a user input mistake to add an empty
Stringas a property to an atom (atom.setProperty(CDKConstants.COMMENT, "")). In this particular case, preventing the exception from bubbling to the surface seems like a good choice to me.I also implemented a few code cleanups in the 2nd commit (unused imports, API call simplifications, method references).