Skip to content

Some small code (clarity) improvements#1172

Merged
johnmay merged 3 commits intomainfrom
nwocdk/code-warning-fixes
Mar 17, 2025
Merged

Some small code (clarity) improvements#1172
johnmay merged 3 commits intomainfrom
nwocdk/code-warning-fixes

Conversation

@egonw
Copy link
Copy Markdown
Member

@egonw egonw commented Mar 16, 2025

No description provided.

@egonw egonw added the cdk2024 label Mar 16, 2025
@egonw egonw requested a review from johnmay March 16, 2025 13:59
Assertions.assertEquals(6.0, BondManipulator.destroyBondOrder(Order.SEXTUPLE), 0.00001);

// above code is deprecated in favor of this:
Assertions.assertEquals(1.0, Order.SINGLE.numeric(), 0.00001);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't these return integers?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If not now this is likely to flag something at some point

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good point. Sorry about that; still very tired it seems :( I will fix this!

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 7a55e8c

@egonw egonw assigned egonw and unassigned johnmay Mar 16, 2025
@sonarqubecloud
Copy link
Copy Markdown

@johnmay johnmay merged commit f286e00 into main Mar 17, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants