Skip to content

@cdk.module and @cdk.githash removal#1171

Merged
johnmay merged 4 commits intomainfrom
nwocdk/remove-cdk.module
Mar 17, 2025
Merged

@cdk.module and @cdk.githash removal#1171
johnmay merged 4 commits intomainfrom
nwocdk/remove-cdk.module

Conversation

@egonw
Copy link
Copy Markdown
Member

@egonw egonw commented Mar 16, 2025

I am now doing this manually, in a plain text editor with: grep -ri "@cdk.module" . | cut -d':' -f1 | head -25 | xargs kate -s random (where random is just a kate session name and can be anything or left out)

Update, after the first commit, the rest was done with a variation of grep -ri "@cdk.githash" . | cut -d':' -f1 | xargs sed -i -e '/cdk.githash/d'

@egonw egonw self-assigned this Mar 16, 2025
@egonw
Copy link
Copy Markdown
Member Author

egonw commented Mar 16, 2025

The fails are not introduced by this patch, as far as I can see.

@egonw egonw changed the title [WIP] First batch of @cdk.module removal @cdk.module and @cdk.githash removal Mar 16, 2025
@egonw egonw added the cdk2024 label Mar 16, 2025
@egonw egonw marked this pull request as ready for review March 16, 2025 13:11
@johnmay
Copy link
Copy Markdown
Member

johnmay commented Mar 16, 2025

this is now in conflict

@egonw egonw force-pushed the nwocdk/remove-cdk.module branch from 5358b28 to dcec78e Compare March 17, 2025 06:10
@egonw
Copy link
Copy Markdown
Member Author

egonw commented Mar 17, 2025

this is now in conflict

Rebased.

@sonarqubecloud
Copy link
Copy Markdown

@johnmay johnmay merged commit 8086444 into main Mar 17, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants