Resolve #523 4 test zero length before access

johnmay · johnmay · commit a9bc131d96f7 · 2019-01-02T22:03:30.000Z
diff --git a/descriptor/qsarbond/src/main/java/org/openscience/cdk/qsar/descriptors/bond/BondSigmaElectronegativityDescriptor.java b/descriptor/qsarbond/src/main/java/org/openscience/cdk/qsar/descriptors/bond/BondSigmaElectronegativityDescriptor.java
@@ -88,13 +88,12 @@ public DescriptorSpecification getSpecification() {
      */
     @Override
     public void setParameters(Object[] params) throws CDKException {
-        if (params.length > 1) {
+        if (params.length > 1)
             throw new CDKException("SigmaElectronegativityDescriptor only expects one parameter");
-        }
-        if (!(params[0] instanceof Integer)) {
+        if (params.length == 0)
+            return;
+        if (!(params[0] instanceof Integer))
             throw new CDKException("The parameter must be of type Integer");
-        }
-        if (params.length == 0) return;
         maxIterations = (Integer) params[0];
     }
 
