The claim that 50-00-0 was the lowest CAS number is false

egonw · egonw · commit 6af48718ef71 · 2021-01-08T21:34:51.000+01:00
diff --git a/misc/extra/src/main/java/org/openscience/cdk/index/CASNumber.java b/misc/extra/src/main/java/org/openscience/cdk/index/CASNumber.java
@@ -73,14 +73,8 @@ public static boolean isValid(String casNumber) {
             String part1 = matcher.group(1);
             String part2 = matcher.group(2);
             String part3 = matcher.group(3);
-            int part1value = Integer.parseInt(part1);
-            if (part1value < 50) {
-                overall = false;
-                // CAS numbers start at 50-00-0
-            } else {
-                int digit = CASNumber.calculateCheckDigit(part1, part2);
-                overall = overall && (digit == Integer.parseInt(part3));
-            }
+            int digit = CASNumber.calculateCheckDigit(part1, part2);
+            overall = overall && (digit == Integer.parseInt(part3));
         }
 
         return overall;
diff --git a/misc/test-extra/src/test/java/org/openscience/cdk/index/CASNumberTest.java b/misc/test-extra/src/test/java/org/openscience/cdk/index/CASNumberTest.java
@@ -1,4 +1,5 @@
 /* Copyright (C) 2003-2007  The Chemistry Development Kit (CDK) project
+ *                    2020  Egon Willighagen <egon.willighagen@gmail.com>
  *
  *  Contact: cdk-devel@lists.sourceforge.net
  *
@@ -38,6 +39,7 @@ public class CASNumberTest extends CDKTestCase {
     @Test
     public void testValidNumbers() {
         // valid cas numbers
+        Assert.assertTrue(CASNumber.isValid("36-88-4"));
         Assert.assertTrue(CASNumber.isValid("50-00-0")); // formaldehyde
         Assert.assertTrue(CASNumber.isValid("548-00-5"));
         Assert.assertTrue(CASNumber.isValid("2622-26-6"));
@@ -59,12 +61,6 @@ public void testInvalidCheckDigits() {
         Assert.assertFalse(CASNumber.isValid("50-00-9"));
     }
 
-    @Test
-    public void testLargerThanFirst() {
-        // valid format, but wrong number, the first is 50-00-0
-        Assert.assertFalse(CASNumber.isValid("3-21-4"));
-    }
-
     @Test
     public void testWrongHyphenPositions() {
         // invalid format due to invalid hyphen positions
