Resolve #523 10 Correct logic, we break when we see a second space. Also use StringBuilder.

johnmay · johnmay · commit 66d52e4ad495 · 2019-01-02T22:24:07.000Z
diff --git a/descriptor/qsaratomic/src/main/java/org/openscience/cdk/qsar/descriptors/atomic/IPAtomicHOSEDescriptor.java b/descriptor/qsaratomic/src/main/java/org/openscience/cdk/qsar/descriptors/atomic/IPAtomicHOSEDescriptor.java
@@ -331,20 +331,19 @@ private HashMap<String, Double> extractAttributes(BufferedReader input) {
      */
     private static List<String> extractInfo(String str) {
 
-        StringBuffer idEdited = new StringBuffer();
-        StringBuffer valEdited = new StringBuffer();
+        StringBuilder idEdited  = new StringBuilder();
+        StringBuilder valEdited = new StringBuilder();
 
         int strlen = str.length();
 
         boolean foundSpace = false;
-        int countSpace = 0;
         boolean foundDigit = false;
         for (int i = 0; i < strlen; i++) {
-            if (!foundDigit) if (Character.isLetter(str.charAt(i))) foundDigit = true;
-
+            if (!foundDigit)
+                if (Character.isLetter(str.charAt(i))) foundDigit = true;
             if (foundDigit) {
                 if (Character.isWhitespace(str.charAt(i))) {
-                    if (countSpace == 0) {
+                    if (!foundSpace) {
                         foundSpace = true;
                     } else
                         break;
@@ -357,7 +356,7 @@ private static List<String> extractInfo(String str) {
                 }
             }
         }
-        List<String> objec = new ArrayList<String>();
+        List<String> objec = new ArrayList<>();
         objec.add(idEdited.toString());
         objec.add(valEdited.toString());
         return objec;
