DecimalFormat not thread safe, just use String.format

johnmay · johnmay · commit 5e4819b56aba · 2019-07-03T10:47:24.000+01:00
diff --git a/tool/sdg/src/main/java/org/openscience/cdk/layout/IdentityTemplateLibrary.java b/tool/sdg/src/main/java/org/openscience/cdk/layout/IdentityTemplateLibrary.java
@@ -45,7 +45,6 @@
 import java.io.OutputStream;
 import java.io.OutputStreamWriter;
 import java.text.DecimalFormat;
-import java.text.DecimalFormatSymbols;
 import java.util.ArrayList;
 import java.util.Collection;
 import java.util.Collections;
@@ -85,8 +84,6 @@
  */
 final class IdentityTemplateLibrary {
 
-    private static final DecimalFormat DECIMAL_FORMAT = new DecimalFormat(".##", DecimalFormatSymbols.getInstance(Locale.ROOT));
-
     private final Multimap<String, Point2d[]> templateMap = LinkedListMultimap.create();
 
     private final SmilesGenerator smigen = SmilesGenerator.unique();
@@ -297,9 +294,10 @@ static String encodeCoordinates(Point2d[] points) {
         sb.append("|(");
         for (Point2d point : points) {
             if (sb.length() > 2) sb.append(";");
-            sb.append(DECIMAL_FORMAT.format(point.x));
+            DecimalFormat fmt;
+            sb.append(String.format(Locale.ROOT, "%.5f", point.x));
             sb.append(',');
-            sb.append(DECIMAL_FORMAT.format(point.y));
+            sb.append(String.format(Locale.ROOT, "%.5f", point.y));
             sb.append(',');
         }
         sb.append(")|");
