Add outputOptionsPrintStringLitsLiterally#68
Closed
expipiplus1 wants to merge 3 commits intocdepillabout:masterfrom
Closed
Add outputOptionsPrintStringLitsLiterally#68expipiplus1 wants to merge 3 commits intocdepillabout:masterfrom
expipiplus1 wants to merge 3 commits intocdepillabout:masterfrom
Conversation
Contributor
Author
|
It would be very nice to turn this on by default, but then one bumps into https://gitlab.haskell.org/ghc/ghc/issues/11529 |
Comment on lines
+74
to
+77
| , outputOptionsEscapeNonPrintable :: Bool | ||
| -- ^ Whether to replace non-printable characters with hexadecimal escape | ||
| -- sequences. | ||
| , outputOptionsPrintStringLitsLiterally :: Bool |
Owner
There was a problem hiding this comment.
Would it make sense to turn these two options into a data type with three constructors?
That might follow the flow of the code better below in the nested if statements.
Contributor
Author
There was a problem hiding this comment.
Done, feel free to suggest some better names.
src/Text/Pretty/Simple.hs
Outdated
Comment on lines
+672
to
+676
| -- >>> pPrintStringOpt CheckColorTty defaultOutputOptionsDarkBg{ outputOptionsPrintStringLitsLiterally = False } "\"Several encodings of A: A \\65 \\065 \\x41 \\n\"" | ||
| -- "Several encodings of A: A A A A " | ||
| -- | ||
| -- >>> pPrintStringOpt CheckColorTty defaultOutputOptionsDarkBg{ outputOptionsPrintStringLitsLiterally = True } "\"Several encodings of A: A \\65 \\065 \\x41 \\n\"" | ||
| -- "Several encodings of A: A \65 \065 \x41 \n" |
Owner
There was a problem hiding this comment.
This is pretty neat! I bet there are definitely users that wanted something like this.
Owner
|
Rebased on top of |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #64