Fix parsing for identifiers containing "'"#65
Fix parsing for identifiers containing "'"#65cdepillabout merged 2 commits intocdepillabout:masterfrom georgefst:master
Conversation
|
Thanks a lot for fixing the bug I caused! :)
That's actually not true: Could you add a test for that? |
Well I never... I must be thinking of a different language. That actually makes me more confident this is correct, although more tests could never hurt. |
|
@georgefst Thanks for fixing this, and @sjakobi thanks for doing a review here! I'd be happy to merge this in once @georgefst adds one small test for constructors like |
|
@cdepillabout Tests added. Just realised you might not have got a notification for that. |
|
Looks good, thanks a lot for fixing this! > data Dont' = Don't' deriving Show
> pPrint ([Right (Just Don't'), Right Nothing, Left 'a' ])
[ Right ( Just Don't' )
, Right Nothing
, Left 'a'
] |
|
Released as 3.2.3.0 on hackage: |
|
Woo! Thanks for the credit. PS. looks like you missed out the |
|
@georgefst However, if you notice it doesn't appear within a couple hours, feel free to ping me and I'll upload it! |
|
Oh cool, I had no idea Hackage did that. |
Closes #63.
This works by simply using the same logic for
'that we use for digits w.r.t. appearing in identifiers. Obviously they're not entirely equivalent in general because'can only appear at the end of an identifier, but I don't believe there's any situation here where that difference is important.