Remove trailing whitespaces from the end of lines#62
Merged
cdepillabout merged 1 commit intocdepillabout:masterfrom Jan 26, 2020
Merged
Remove trailing whitespaces from the end of lines#62cdepillabout merged 1 commit intocdepillabout:masterfrom
cdepillabout merged 1 commit intocdepillabout:masterfrom
Conversation
Owner
|
@ghallak Thanks for trying to fix this. It looks like CI is now failing on some of the doctests with this improvement. Could you fix these up? https://travis-ci.org/cdepillabout/pretty-simple/jobs/641713245#L468 |
Contributor
Author
|
I have fixed the doctests expectations and squashed the commits. The CI checks are passing now. |
Owner
|
Looks good to me. Thanks! |
Owner
|
@ghallak I wasn't planning on creating a Hackage release for this feature, but if you'd like one, please let me know! |
Contributor
Author
|
I think it's fine without a Hackage release for this feature, the fixed issue was not causing the biggest problems. |
|
I would appreciate a Hackage release including this feature. |
Owner
|
No problem, released |
|
Great! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #61