Skip to content

Fix handling of Char literals#57

Merged
cdepillabout merged 3 commits intocdepillabout:masterfrom
sjakobi:45-char
Dec 21, 2019
Merged

Fix handling of Char literals#57
cdepillabout merged 3 commits intocdepillabout:masterfrom
sjakobi:45-char

Conversation

@sjakobi
Copy link
Copy Markdown
Contributor

@sjakobi sjakobi commented Dec 12, 2019

Fixes #45.

@cdepillabout
Copy link
Copy Markdown
Owner

I only did a quick skim over this, but it looks pretty good! Give me a week or so to do a thorough review of this.

@cdepillabout
Copy link
Copy Markdown
Owner

@sjakobi Sorry for making you wait for this.

In 0b95aec I added some tests and fixed up a small problem with parsing other characters.

@cdepillabout cdepillabout merged commit 6c842d7 into cdepillabout:master Dec 21, 2019
@cdepillabout
Copy link
Copy Markdown
Owner

Bumped version and released to hackage:

https://hackage.haskell.org/package/pretty-simple-3.2.0.0

@sjakobi sjakobi deleted the 45-char branch December 21, 2019 14:17
@sjakobi
Copy link
Copy Markdown
Contributor Author

sjakobi commented Dec 21, 2019

No worries and many thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

the parser doesn't understand Haskell characters like 'a'

2 participants